qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gtk: Add show_tabs=on|off command line option.


From: Felix Queißner
Subject: Re: [PATCH] gtk: Add show_tabs=on|off command line option.
Date: Tue, 12 Jul 2022 09:35:44 +0200

Heya!

On 27.06.22 18:44, Felix xq Queißner wrote:
The patch adds "show_tabs" command line option for GTK ui similar to 
"grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at 
each start of the VM.

On 30.06.22 16:09, Hanna Reitz wrote:
> [snip]

On 30.06.22 16:53, Markus Armbruster wrote:
> [snip]

On 01.07.22 12:00, Gerd Hoffmann wrote:
> [snip]

I have addressed the things mentioned:
- limiting line length to 80 in ui.json, qemu-options.hx
- limiting line length in commit to 72
- improved description of the option as Hanna suggested

On 01.07.22 11:14, Zhang, Chen wrote:
>> Signed-off-by: Felix "xq" Queißner <xq@random-projects.net>
>
> Thanks your patch, but please use your real name to sign a patch.

Not sure what to do about this one. Felix Queißer *is* my real name, so the only thing i could do is to remove the "xq"?

Should i submit my changes as a response to this or create a new mail thread with a new patch?

Regards
- Felix



reply via email to

[Prev in Thread] Current Thread [Next in Thread]