qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 7/8] target/mips: Simplify UHI_argnlen and UHI_argn


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v5 7/8] target/mips: Simplify UHI_argnlen and UHI_argn
Date: Tue, 12 Jul 2022 22:22:47 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 28/6/22 13:17, Richard Henderson wrote:
With semihosting_get_arg, we already have a check vs argc, so
there's no point replicating it -- just check the result vs NULL.
Merge copy_argn_to_target into its caller.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  target/mips/tcg/sysemu/mips-semi.c | 44 ++++++++++++++----------------
  1 file changed, 21 insertions(+), 23 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]