[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 5/5] avocado: Fix BUILD_DIR if it's equal to SOURCE_DIR
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 5/5] avocado: Fix BUILD_DIR if it's equal to SOURCE_DIR |
Date: |
Wed, 13 Jul 2022 00:16:07 +0200 |
From: Peter Delevoryas <peter@pjd.dev>
I like to build QEMU from the root source directory [*], rather
than cd'ing into the build directory. This code may as well include
a search path for that, so that you can run avocado tests individually
without specifying "-p qemu_bin=build/qemu-system-arm" manually.
[*] See commit dedad02720 ("configure: add support for pseudo-"in source tree"
builds")
Signed-off-by: Peter Delevoryas <peter@pjd.dev>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220702185604.46643-1-peter@pjd.dev>
[PMD: Mention commit dedad02720]
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
tests/avocado/avocado_qemu/__init__.py | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/tests/avocado/avocado_qemu/__init__.py
b/tests/avocado/avocado_qemu/__init__.py
index b656a70c55..ed4853c805 100644
--- a/tests/avocado/avocado_qemu/__init__.py
+++ b/tests/avocado/avocado_qemu/__init__.py
@@ -120,14 +120,15 @@ def pick_default_qemu_bin(bin_prefix='qemu-system-',
arch=None):
# qemu binary path does not match arch for powerpc, handle it
if 'ppc64le' in arch:
arch = 'ppc64'
- qemu_bin_relative_path = os.path.join(".", bin_prefix + arch)
- if is_readable_executable_file(qemu_bin_relative_path):
- return qemu_bin_relative_path
-
- qemu_bin_from_bld_dir_path = os.path.join(BUILD_DIR,
- qemu_bin_relative_path)
- if is_readable_executable_file(qemu_bin_from_bld_dir_path):
- return qemu_bin_from_bld_dir_path
+ qemu_bin_name = bin_prefix + arch
+ qemu_bin_paths = [
+ os.path.join(".", qemu_bin_name),
+ os.path.join(BUILD_DIR, qemu_bin_name),
+ os.path.join(BUILD_DIR, "build", qemu_bin_name),
+ ]
+ for path in qemu_bin_paths:
+ if is_readable_executable_file(path):
+ return path
return None
--
2.36.1
- [PULL 0/5] Darwin patches for 2022-07-12, Philippe Mathieu-Daudé, 2022/07/12
- [PULL 1/5] hvf: Enable RDTSCP support, Philippe Mathieu-Daudé, 2022/07/12
- [PULL 2/5] configure: Restrict TCG to emulation, Philippe Mathieu-Daudé, 2022/07/12
- [PULL 3/5] ui/cocoa: Fix switched_to_fullscreen warning, Philippe Mathieu-Daudé, 2022/07/12
- [PULL 4/5] ui/cocoa: Take refresh rate into account, Philippe Mathieu-Daudé, 2022/07/12
- [PULL 5/5] avocado: Fix BUILD_DIR if it's equal to SOURCE_DIR,
Philippe Mathieu-Daudé <=
- Re: [PULL 0/5] Darwin patches for 2022-07-12, Peter Maydell, 2022/07/14