[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 1/3] MAINTAINERS: Add myself as Guest Agent reviewer
From: |
Daniel P . Berrangé |
Subject: |
Re: [PULL 1/3] MAINTAINERS: Add myself as Guest Agent reviewer |
Date: |
Wed, 13 Jul 2022 11:38:15 +0100 |
User-agent: |
Mutt/2.2.6 (2022-06-05) |
On Wed, Jul 13, 2022 at 01:19:06PM +0300, Konstantin Kostiuk wrote:
> Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
> Message-Id: <20220712092715.2136898-1-kkostiuk@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 450abd0252..b1e73d99f3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2880,6 +2880,7 @@ T: git https://repo.or.cz/qemu/armbru.git qapi-next
>
> QEMU Guest Agent
> M: Michael Roth <michael.roth@amd.com>
> +R: Konstantin Kostiuk <kkostiuk@redhat.com>
This pull request contains functional changes under qga/, which
suggests you're acting as a (co-)maintainer for QGA, not merely
a reviewer. I wouldn't normally expect reviewers to send pull
requests for a subsystem. As such should this be "M:", to
indicate co-maintainership and have an explicit ACK from
Michael Roth.
> S: Maintained
> F: qga/
> F: docs/interop/qemu-ga.rst
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
[PULL 2/3] qapi: Avoid generating C identifier 'linux', Konstantin Kostiuk, 2022/07/13
[PULL 3/3] qga: add command 'guest-get-cpustats', Konstantin Kostiuk, 2022/07/13
Re: [PULL 0/3] Guest Agent patches 2022-07-13, Peter Maydell, 2022/07/14