Re: [PATCH v6 12/13] qemu-sockets: update socket_uri() to be consistent with socket_parse()

[Laurent Vivier]

On 12/07/2022 14:05, Dr. David Alan Gilbert wrote:
> * Laurent Vivier (lvivier@redhat.com) wrote:
> > Remove 'tcp:' prefix for inet type (because inet can be 'tcp' or 'udp'
> > and socket_parse() doesn't recognize it), the format is 'host:port'.
>
> I don't think I understand why tests/qtest/migration-test.c
> test_precopy_common is happy with this; it does:
>
>      if (!args->connect_uri) {
>          g_autofree char *local_connect_uri =
>              migrate_get_socket_address(to, "socket-address");
>          migrate_qmp(from, local_connect_uri, "{}");
>
> which hmm, is the code you're changing what was in SocketAddress_to_str
> which is what migrate_get_socket_address uses; but then the migrate_qmp
> I don't think will take a migrate uri without the tcp: on the front.

It's a good point.

I think socket_parse() should accept the 'tcp:' prefix, and thus socket_uri() should 
generate it, so it will be usable with the qmp migrate command.

I'm going to add 'tcp:' case in socket_parse() and make socket_uri() to 
generate it.

Thanks,
Laurent