[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 03/12] vdpa: Small rename of error labels
From: |
Eugenio Perez Martin |
Subject: |
Re: [RFC PATCH 03/12] vdpa: Small rename of error labels |
Date: |
Mon, 18 Jul 2022 09:21:31 +0200 |
On Mon, Jul 18, 2022 at 7:50 AM Jason Wang <jasowang@redhat.com> wrote:
>
> On Sat, Jul 16, 2022 at 7:34 PM Eugenio Pérez <eperezma@redhat.com> wrote:
> >
> > So later patches are cleaner
> >
> > Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> > ---
> > hw/virtio/vhost-vdpa.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
> > index 4458c8d23e..906c365036 100644
> > --- a/hw/virtio/vhost-vdpa.c
> > +++ b/hw/virtio/vhost-vdpa.c
> > @@ -1039,7 +1039,7 @@ static bool vhost_vdpa_svqs_start(struct vhost_dev
> > *dev)
> > int r;
> > bool ok = vhost_vdpa_svq_setup(dev, svq, i, &err);
> > if (unlikely(!ok)) {
> > - goto err;
> > + goto err_svq_setup;
> > }
> >
> > vhost_svq_start(svq, dev->vdev, vq);
> > @@ -1064,8 +1064,7 @@ err_set_addr:
> > err_map:
> > vhost_svq_stop(g_ptr_array_index(v->shadow_vqs, i));
> >
> > -err:
> > - error_reportf_err(err, "Cannot setup SVQ %u: ", i);
>
> This does not look like a simple rename.
>
That's right.
I'll drop his patch from the series, it's not really useful and only adds noise.
Thanks!
> Thanks
>
> > +err_svq_setup:
> > for (unsigned j = 0; j < i; ++j) {
> > VhostShadowVirtqueue *svq = g_ptr_array_index(v->shadow_vqs, j);
> > vhost_vdpa_svq_unmap_rings(dev, svq);
> > --
> > 2.31.1
> >
>
- [RFC PATCH 00/12] NIC vhost-vdpa state restore via Shadow CVQ, Eugenio Pérez, 2022/07/16
- [RFC PATCH 01/12] vhost: Get vring base from vq, not svq, Eugenio Pérez, 2022/07/16
- [RFC PATCH 02/12] vhost: Move SVQ queue rewind to the destination, Eugenio Pérez, 2022/07/16
- [RFC PATCH 03/12] vdpa: Small rename of error labels, Eugenio Pérez, 2022/07/16
- [RFC PATCH 04/12] vdpa: delay set_vring_ready after DRIVER_OK, Eugenio Pérez, 2022/07/16
- [RFC PATCH 06/12] vhost: Use opaque data in SVQDescState, Eugenio Pérez, 2022/07/16
- [RFC PATCH 05/12] vhost: stop transfer elem ownership in vhost_handle_guest_kick, Eugenio Pérez, 2022/07/16
- [RFC PATCH 07/12] vhost: Add VhostVDPAStartOp operation, Eugenio Pérez, 2022/07/16
- [RFC PATCH 08/12] vdpa: Add vhost_vdpa_start_control_svq, Eugenio Pérez, 2022/07/16