[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/6] dbus-display: fix test race when initializing p2p connection
From: |
Gerd Hoffmann |
Subject: |
[PULL 1/6] dbus-display: fix test race when initializing p2p connection |
Date: |
Tue, 19 Jul 2022 17:22:13 +0200 |
From: Marc-André Lureau <marcandre.lureau@redhat.com>
The D-Bus connection starts processing messages before QEMU has the time
to set the object manager server. This is causing dbus-display-test to
fail randomly with:
ERROR:../tests/qtest/dbus-display-test.c:68:test_dbus_display_vm:
assertion failed
(qemu_dbus_display1_vm_get_name(QEMU_DBUS_DISPLAY1_VM(vm)) ==
"dbus-test"): (NULL == "dbus-test") ERROR
Use the delayed message processing flag and method to avoid that
situation.
(the bus connection doesn't need a fix, as the initialization is done
synchronously)
Reported-by: Robinson, Cole <crobinso@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Tested-by: Cole Robinson <crobinso@redhat.com>
Message-Id: <20220609152647.870373-1-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/dbus.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ui/dbus.c b/ui/dbus.c
index 7a87612379e8..32d88dc94a7e 100644
--- a/ui/dbus.c
+++ b/ui/dbus.c
@@ -268,6 +268,7 @@ dbus_display_add_client_ready(GObject *source_object,
}
g_dbus_object_manager_server_set_connection(dbus_display->server, conn);
+ g_dbus_connection_start_message_processing(conn);
}
@@ -300,7 +301,8 @@ dbus_display_add_client(int csock, Error **errp)
g_dbus_connection_new(G_IO_STREAM(conn),
guid,
- G_DBUS_CONNECTION_FLAGS_AUTHENTICATION_SERVER,
+ G_DBUS_CONNECTION_FLAGS_AUTHENTICATION_SERVER |
+ G_DBUS_CONNECTION_FLAGS_DELAY_MESSAGE_PROCESSING,
NULL,
dbus_display->add_client_cancellable,
dbus_display_add_client_ready,
--
2.36.1
- [PULL 0/6] Kraxel 20220719 patches, Gerd Hoffmann, 2022/07/19
- [PULL 1/6] dbus-display: fix test race when initializing p2p connection,
Gerd Hoffmann <=
- [PULL 3/6] usb/hcd-xhci: check slotid in xhci_wakeup_endpoint(), Gerd Hoffmann, 2022/07/19
- [PULL 2/6] microvm: turn off io reservations for pcie root ports, Gerd Hoffmann, 2022/07/19
- [PULL 4/6] usb: document guest-reset and guest-reset-all, Gerd Hoffmann, 2022/07/19
- [PULL 5/6] usb: document pcap (aka usb traffic capture), Gerd Hoffmann, 2022/07/19
- [PULL 6/6] gtk: Add show_tabs=on|off command line option., Gerd Hoffmann, 2022/07/19
- Re: [PULL 0/6] Kraxel 20220719 patches, Peter Maydell, 2022/07/19