RE: [PATCH] softmmu/physmem: Fix input parameters for flatview_access_allowed()

[Duan, Zhenzhong]

>-----Original Message-----
>From: Peter Xu <peterx@redhat.com>
>Sent: Thursday, June 23, 2022 5:03 AM
>To: Duan, Zhenzhong <zhenzhong.duan@intel.com>
>Cc: qemu-devel@nongnu.org; pbonzini@redhat.com; david@redhat.com;
>f4bug@amsat.org
>Subject: Re: [PATCH] softmmu/physmem: Fix input parameters for
>flatview_access_allowed()
>
>On Wed, Jun 22, 2022 at 09:28:39AM +0800, Zhenzhong Duan wrote:
>> The comment of flatview_access_allowed() suggests to pass address
>> within that memory region, this isn't ture in some call sites.
>>
>> This makes qemu log in flatview_access_allowed() confusing and
>> potential risk if the input parameter will be checked in the future.
>>
>> Fixes: 3ab6fdc91b72 ("softmmu/physmem: Introduce MemTxAttrs::memory
>> field and MEMTX_ACCESS_ERROR")
>> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
>
>Reviewed-by: Peter Xu <peterx@redhat.com>
Hi,

No progress for a long time, any further comments? Thanks!

Zhenzhong