[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/8] accel/kvm: Avoid Coverity warning in query_stats()
From: |
Paolo Bonzini |
Subject: |
[PULL 2/8] accel/kvm: Avoid Coverity warning in query_stats() |
Date: |
Fri, 22 Jul 2022 19:04:43 +0200 |
From: Peter Maydell <peter.maydell@linaro.org>
Coverity complains that there is a codepath in the query_stats()
function where it can leak the memory pointed to by stats_list. This
can only happen if the caller passes something other than
STATS_TARGET_VM or STATS_TARGET_VCPU as the 'target', which no
callsite does. Enforce this assumption using g_assert_not_reached(),
so that if we have a future bug we hit the assert rather than
silently leaking memory.
Resolves: Coverity CID 1490140
Fixes: cc01a3f4cadd91e6 ("kvm: Support for querying fd-based stats")
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20220719134853.327059-1-peter.maydell@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
accel/kvm/kvm-all.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index 99aede73b7..f165074e99 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -4014,7 +4014,7 @@ static void query_stats(StatsResultList **result,
StatsTarget target,
stats_list);
break;
default:
- break;
+ g_assert_not_reached();
}
}
--
2.36.1
- [PULL v2 0/8] More fixes + random seed patches for QEMU 7.1, Paolo Bonzini, 2022/07/22
- [PULL 4/8] oss-fuzz: ensure base_copy is a generic-fuzzer, Paolo Bonzini, 2022/07/22
- [PULL 3/8] oss-fuzz: remove binaries from qemu-bundle tree, Paolo Bonzini, 2022/07/22
- [PULL 1/8] docs: Add caveats for Windows as the build platform, Paolo Bonzini, 2022/07/22
- [PULL 7/8] hw/rx: pass random seed to fdt, Paolo Bonzini, 2022/07/22
- [PULL 2/8] accel/kvm: Avoid Coverity warning in query_stats(),
Paolo Bonzini <=
- [PULL 5/8] hw/nios2: virt: pass random seed to fdt, Paolo Bonzini, 2022/07/22
- [PULL 6/8] hw/mips: boston: pass random seed to fdt, Paolo Bonzini, 2022/07/22
- [PULL 8/8] hw/i386: pass RNG seed via setup_data entry, Paolo Bonzini, 2022/07/22
- Re: [PULL v2 0/8] More fixes + random seed patches for QEMU 7.1, Peter Maydell, 2022/07/25