[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 05/17] dump: Cleanup and annotate guest memory related DumpSta
From: |
Janosch Frank |
Subject: |
[PATCH v4 05/17] dump: Cleanup and annotate guest memory related DumpState struct members |
Date: |
Tue, 26 Jul 2022 09:22:36 +0000 |
We can safely remove next_block and start as both of them aren't used
anymore due to the block iteration re-work.
Also we add comments to the remaining guest memory related struct
members and a comment on top to group them.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
include/sysemu/dump.h | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/include/sysemu/dump.h b/include/sysemu/dump.h
index 6ce3c24197..24ebb02660 100644
--- a/include/sysemu/dump.h
+++ b/include/sysemu/dump.h
@@ -166,11 +166,10 @@ typedef struct DumpState {
hwaddr memory_offset;
int fd;
- GuestPhysBlock *next_block;
- ram_addr_t start;
- bool has_filter;
- int64_t begin;
- int64_t length;
+ /* Guest memory related data */
+ bool has_filter; /* Are we dumping parts of the memory? */
+ int64_t begin; /* Start address of the chunk we want to dump */
+ int64_t length; /* Length of the dump we want to dump */
uint8_t *note_buf; /* buffer for notes */
size_t note_buf_offset; /* the writing place in note_buf */
--
2.34.1
- [PATCH v4 00/17] dump: Add arch section and s390x PV dump, Janosch Frank, 2022/07/26
- [PATCH v4 01/17] dump: Rename write_elf_loads to write_elf_phdr_loads, Janosch Frank, 2022/07/26
- [PATCH v4 05/17] dump: Cleanup and annotate guest memory related DumpState struct members,
Janosch Frank <=
- [PATCH v4 03/17] dump: Convert GuestPhysBlock iterators and use the filter functions, Janosch Frank, 2022/07/26
- [PATCH v4 04/17] dump: Rework get_start_block, Janosch Frank, 2022/07/26
- [PATCH v4 08/17] dump: Split write of section headers and data and add a prepare step, Janosch Frank, 2022/07/26