[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 5/9] configure: Add braces to clarify intent of $emu[[:space:]]
From: |
Peter Maydell |
Subject: |
[PULL 5/9] configure: Add braces to clarify intent of $emu[[:space:]] |
Date: |
Tue, 26 Jul 2022 16:20:08 +0100 |
In shell script syntax, $var[something] is not special for variable
expansion: $var is expanded. However, as it can look as if it were
intended to be an array element access (the correct syntax for which
is ${var[something]}), shellcheck recommends using explicit braces
around ${var} to clarify the intended expansion.
This fixes the warning:
In ./configure line 2346:
if "$target_ld" -verbose 2>&1 | grep -q
"^[[:space:]]*$emu[[:space:]]*$"; then
^-- SC1087: Use
braces when expanding arrays, e.g. ${array[idx]} (or ${var}[.. to quiet).
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-id: 20220720152631.450903-3-peter.maydell@linaro.org
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index dec6f030346..a56c3d921be 100755
--- a/configure
+++ b/configure
@@ -2343,7 +2343,7 @@ if test -n "$target_cc" &&
# emulation. Linux and OpenBSD/amd64 use 'elf_i386'; FreeBSD uses the _fbsd
# variant; OpenBSD/i386 uses the _obsd variant; and Windows uses i386pe.
for emu in elf_i386 elf_i386_fbsd elf_i386_obsd i386pe; do
- if "$target_ld" -verbose 2>&1 | grep -q
"^[[:space:]]*$emu[[:space:]]*$"; then
+ if "$target_ld" -verbose 2>&1 | grep -q
"^[[:space:]]*${emu}[[:space:]]*$"; then
ld_i386_emulation="$emu"
break
fi
--
2.25.1
- [PULL 9/9] target/arm: Fix qemu-system-arm handling of LPAE block descriptors for highmem, (continued)
- [PULL 9/9] target/arm: Fix qemu-system-arm handling of LPAE block descriptors for highmem, Peter Maydell, 2022/07/07
- [PULL 8/9] target/arm: Correctly implement Feat_DoubleLock, Peter Maydell, 2022/07/07
- Re: [PULL 0/9] target-arm queue, Richard Henderson, 2022/07/07
- [PULL 0/9] target-arm queue, Peter Maydell, 2022/07/26
- [PULL 1/9] scripts/coverity-scan/COMPONENTS.md: Add loongarch component, Peter Maydell, 2022/07/26
- [PULL 2/9] scripts/coverity-scan/COMPONENTS.md: Update slirp component info, Peter Maydell, 2022/07/26
- [PULL 8/9] configure: Avoid '==' bashism, Peter Maydell, 2022/07/26
- [PULL 3/9] target/arm: Add MO_128 entry to pred_esz_masks[], Peter Maydell, 2022/07/26
- [PULL 7/9] configure: Drop dead code attempting to use -msmall-data on alpha hosts, Peter Maydell, 2022/07/26
- [PULL 4/9] configure: Add missing POSIX-required space, Peter Maydell, 2022/07/26
- [PULL 5/9] configure: Add braces to clarify intent of $emu[[:space:]],
Peter Maydell <=
- [PULL 6/9] configure: Don't use bash-specific string-replacement syntax, Peter Maydell, 2022/07/26
- [PULL 9/9] hw/display/bcm2835_fb: Fix framebuffer allocation address, Peter Maydell, 2022/07/26
- Re: [PULL 0/9] target-arm queue, Richard Henderson, 2022/07/26