[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 09/21] hw/virtio: fix vhost_user_read tracepoint
From: |
Alex Bennée |
Subject: |
[PATCH v3 09/21] hw/virtio: fix vhost_user_read tracepoint |
Date: |
Tue, 26 Jul 2022 20:21:38 +0100 |
As reads happen in the callback we were never seeing them. We only
really care about the header so move the tracepoint to when the header
is complete.
Fixes: 6ca6d8ee9d (hw/virtio: add vhost_user_[read|write] trace points)
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
hw/virtio/vhost-user.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index a96a586ebf..b7c13e7e16 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -296,6 +296,8 @@ static int vhost_user_read_header(struct vhost_dev *dev,
VhostUserMsg *msg)
return -EPROTO;
}
+ trace_vhost_user_read(msg->hdr.request, msg->hdr.flags);
+
return 0;
}
@@ -545,8 +547,6 @@ static int vhost_user_set_log_base(struct vhost_dev *dev,
uint64_t base,
}
}
- trace_vhost_user_read(msg.hdr.request, msg.hdr.flags);
-
return 0;
}
--
2.30.2
- [PATCH v3 06/21] hw/virtio: incorporate backend features in features, (continued)
- [PATCH v3 06/21] hw/virtio: incorporate backend features in features, Alex Bennée, 2022/07/26
- [PATCH v3 20/21] tests/qtest: add a get_features op to vhost-user-test, Alex Bennée, 2022/07/26
- [PATCH v3 04/21] hw/virtio: log potentially buggy guest drivers, Alex Bennée, 2022/07/26
- [PATCH v3 05/21] block/vhost-user-blk-server: don't expose VHOST_USER_F_PROTOCOL_FEATURES, Alex Bennée, 2022/07/26
- [PATCH v3 07/21] hw/virtio: gracefully handle unset vhost_dev vdev, Alex Bennée, 2022/07/26
- [PATCH v3 08/21] hw/virtio: handle un-configured shutdown in virtio-pci, Alex Bennée, 2022/07/26
- [PATCH v3 09/21] hw/virtio: fix vhost_user_read tracepoint,
Alex Bennée <=
- [PATCH v3 17/21] tests/qtest: plain g_assert for VHOST_USER_F_PROTOCOL_FEATURES, Alex Bennée, 2022/07/26
- [PATCH v3 21/21] tests/qtest: enable tests for virtio-gpio, Alex Bennée, 2022/07/26
- [PATCH v3 19/21] tests/qtest: implement stub for VHOST_USER_GET_CONFIG, Alex Bennée, 2022/07/26
- [PATCH v3 13/21] tests/qtest: pass stdout/stderr down to subtests, Alex Bennée, 2022/07/26
- [PATCH v3 16/21] tests/qtest: catch unhandled vhost-user messages, Alex Bennée, 2022/07/26
- [PATCH v3 12/21] hw/virtio: add vhost-user-gpio-pci boilerplate, Alex Bennée, 2022/07/26
- [PATCH v3 10/21] hw/virtio: add some vhost-user trace events, Alex Bennée, 2022/07/26
- [PATCH v3 11/21] hw/virtio: add boilerplate for vhost-user-gpio device, Alex Bennée, 2022/07/26
- [PATCH v3 18/21] tests/qtest: add assert to catch bad features, Alex Bennée, 2022/07/26