Re: [PATCH 1/3] qga: Replace 'blacklist' command line and config file options by 'block-rpcs'

[Konstantin Kostiuk]

Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>

On Wed, Jul 27, 2022 at 12:29 PM Daniel P. Berrangé <berrange@redhat.com> wrote:

On Wed, Jul 27, 2022 at 11:21:33AM +0200, Thomas Huth wrote:
> Let's use a more appropriate wording for this command line and config
> file option. The old ones are still accepted for compatibility reasons,
> but marked as deprecated now so that it could be removed in a future
> version of QEMU.
>
> This change is based on earlier patches from Philippe Mathieu-Daudé,
> with the idea for the new option name suggested by BALATON Zoltan.
>
> And while we're at it, replace the "?" in the help text with "help"
> since that does not have the problem of conflicting with the wildcard
> character of the shells.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  docs/about/deprecated.rst  | 19 +++++++++++++++++++
>  docs/interop/qemu-ga.rst   |  8 ++++----
>  qga/main.c                 | 18 +++++++++++++-----
>  tests/unit/test-qga.c      |  2 +-
>  tests/data/test-qga-config |  2 +-
>  5 files changed, 38 insertions(+), 11 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
--
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|