[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 2/6] multifd: Protect multifd_send_sync_main() calls
From: |
Juan Quintela |
Subject: |
[PATCH v2 2/6] multifd: Protect multifd_send_sync_main() calls |
Date: |
Thu, 28 Jul 2022 13:59:53 +0200 |
We only need to do that on the ram_save_iterate() call on sending and
on destination when we get a RAM_SAVE_FLAG_EOS.
In setup() and complete() we need to synch in both new and old cases,
so don't add a check there.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
Remove the wrappers that we take out on patch 5.
---
migration/ram.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index b94669ba5d..6b71ce74f6 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -3338,9 +3338,11 @@ static int ram_save_iterate(QEMUFile *f, void *opaque)
out:
if (ret >= 0
&& migration_is_setup_or_active(migrate_get_current()->state)) {
- ret = multifd_send_sync_main(rs->f);
- if (ret < 0) {
- return ret;
+ if (migrate_multifd_sync_after_each_section()) {
+ ret = multifd_send_sync_main(rs->f);
+ if (ret < 0) {
+ return ret;
+ }
}
qemu_put_be64(f, RAM_SAVE_FLAG_EOS);
@@ -4084,7 +4086,9 @@ int ram_load_postcopy(QEMUFile *f, int channel)
case RAM_SAVE_FLAG_EOS:
/* normal exit */
- multifd_recv_sync_main();
+ if (migrate_multifd_sync_after_each_section()) {
+ multifd_recv_sync_main();
+ }
break;
default:
error_report("Unknown combination of migration flags: 0x%x"
@@ -4361,7 +4365,9 @@ static int ram_load_precopy(QEMUFile *f)
break;
case RAM_SAVE_FLAG_EOS:
/* normal exit */
- multifd_recv_sync_main();
+ if (migrate_multifd_sync_after_each_section()) {
+ multifd_recv_sync_main();
+ }
break;
default:
if (flags & RAM_SAVE_FLAG_HOOK) {
--
2.37.1
- [PATCH v2 0/6] Eliminate multifd flush, Juan Quintela, 2022/07/28
- [PATCH v2 1/6] multifd: Create property multifd-sync-after-each-section, Juan Quintela, 2022/07/28
- [PATCH v2 3/6] migration: Simplify ram_find_and_save_block(), Juan Quintela, 2022/07/28
- [PATCH v2 2/6] multifd: Protect multifd_send_sync_main() calls,
Juan Quintela <=
- [PATCH v2 6/6] ram: Document migration ram flags, Juan Quintela, 2022/07/28
- [PATCH v2 5/6] multifd: Only sync once each full round of memory, Juan Quintela, 2022/07/28
- [PATCH v2 4/6] migration: Make find_dirty_block() return a single parameter, Juan Quintela, 2022/07/28