[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-7.1] applesmc: silence invalid key warning in case defaul
From: |
Igor Mammedov |
Subject: |
Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used |
Date: |
Thu, 28 Jul 2022 15:39:50 +0200 |
On Thu, 28 Jul 2022 15:29:58 +0200
Markus Armbruster <armbru@redhat.com> wrote:
> Peter Maydell <peter.maydell@linaro.org> writes:
>
> > On Thu, 28 Jul 2022 at 11:23, Daniel P. Berrangé <berrange@redhat.com>
> > wrote:
> >>
> >> On Thu, Jul 28, 2022 at 11:05:13AM +0100, Peter Maydell wrote:
> >> > On Thu, 28 Jul 2022 at 10:48, Daniel P. Berrangé <berrange@redhat.com>
> >> > wrote:
> >> > >
> >> > > On Thu, Jul 28, 2022 at 05:35:58AM -0400, Igor Mammedov wrote:
> >> > > > QEMU probably can't carry OSK key[1] for legal reasons so it
> >> > > > can't supply the valid default key. However when tests are run
> >> > > > applesmc will pollute test log with distracting warning,
> >> > > > silence that warning so it won't distract maintainers/CI.
> >> > >
> >> > > What test is causing this problem ?
> >> >
> >> > bios-tables-test -- see here for the relevant bit of the log:
> >> >
> >> > https://lore.kernel.org/qemu-devel/CAFEAcA8u8jm7b+JD_t0qMNMy+WSJPOw=qxqptZpwTp=TkcXrhg@mail.gmail.com/
> >> >
> >>
> >> The right fix is for bios-tables-tests to pass an explicit 'osk' value
> >> then. As its a test it doesn't have to be a genuine OSK, jsut any old
> >> 64-byte string
> >>
> >> diff --git a/tests/qtest/bios-tables-test.c
> >> b/tests/qtest/bios-tables-test.c
> >> index 359916c228..f6b5adf200 100644
> >> --- a/tests/qtest/bios-tables-test.c
> >> +++ b/tests/qtest/bios-tables-test.c
> >> @@ -1632,7 +1632,7 @@ static void test_acpi_q35_applesmc(void)
> >> .variant = ".applesmc",
> >> };
> >>
> >> - test_acpi_one("-device isa-applesmc", &data);
> >> + test_acpi_one("-device
> >> isa-applesmc,osk=iamalsonottherealoskimjustheretostopbiostablestestspammingstderr",
> >> &data);
> >> free_test_data(&data);
> >
> > We should either have a comment saying that this has to be exactly
> > 64 characters and it doesn't matter what they are; or we could use
> > any64characterfakeoskisenoughtopreventinvalidkeywarningsonstderr
> >
> > :-)
>
> I applaud the renaissance of roman-style inscriptions, but it's not just
> words without spaces, it's also capital letters only:
>
> ANY64CHARACTERFAKEOSKISENOUGHTOPREVENTINVALIDKEYWARNINGSONSTDERR
>
> Seriously, throw in some dashes or spaces.
too late, but added a comment above hieroglyphs style string
>
- [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used, Igor Mammedov, 2022/07/28
- Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used, Daniel P . Berrangé, 2022/07/28
- Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used, Peter Maydell, 2022/07/28
- Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used, Daniel P . Berrangé, 2022/07/28
- Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used, Peter Maydell, 2022/07/28
- Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used, Markus Armbruster, 2022/07/28
- Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used,
Igor Mammedov <=
- Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used, Peter Maydell, 2022/07/28
- Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used, Daniel P . Berrangé, 2022/07/28
- Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used, Markus Armbruster, 2022/07/28
- Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used, Igor Mammedov, 2022/07/28
- Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used, Daniel P . Berrangé, 2022/07/28
Re: [PATCH for-7.1] applesmc: silence invalid key warning in case default one is used, Igor Mammedov, 2022/07/28