[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 5/6] kvm: don't use perror() without useful errno
From: |
Paolo Bonzini |
Subject: |
[PULL 5/6] kvm: don't use perror() without useful errno |
Date: |
Fri, 29 Jul 2022 17:04:37 +0200 |
From: Cornelia Huck <cohuck@redhat.com>
perror() is designed to append the decoded errno value to a
string. This, however, only makes sense if we called something that
actually sets errno prior to that.
For the callers that check for split irqchip support that is not the
case, and we end up with confusing error messages that end in
"success". Use error_report() instead.
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Message-Id: <20220728142446.438177-1-cohuck@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
accel/kvm/kvm-all.c | 2 +-
target/arm/kvm.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index f165074e99..645f0a249a 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -2265,7 +2265,7 @@ static void kvm_irqchip_create(KVMState *s)
ret = kvm_arch_irqchip_create(s);
if (ret == 0) {
if (s->kernel_irqchip_split == ON_OFF_AUTO_ON) {
- perror("Split IRQ chip mode not supported.");
+ error_report("Split IRQ chip mode not supported.");
exit(1);
} else {
ret = kvm_vm_ioctl(s, KVM_CREATE_IRQCHIP);
diff --git a/target/arm/kvm.c b/target/arm/kvm.c
index 4339e1cd6e..e5c1bd50d2 100644
--- a/target/arm/kvm.c
+++ b/target/arm/kvm.c
@@ -959,7 +959,7 @@ void kvm_arch_init_irq_routing(KVMState *s)
int kvm_arch_irqchip_create(KVMState *s)
{
if (kvm_kernel_irqchip_split()) {
- perror("-machine kernel_irqchip=split is not supported on ARM.");
+ error_report("-machine kernel_irqchip=split is not supported on ARM.");
exit(1);
}
--
2.36.1
- [PULL 0/6] Fixes for QEMU 7.1-rc1, Paolo Bonzini, 2022/07/29
- [PULL 1/6] ui: dbus-display requires CONFIG_GBM, Paolo Bonzini, 2022/07/29
- [PULL 2/6] vga: fix incorrect line height in 640x200x2 mode, Paolo Bonzini, 2022/07/29
- [PULL 4/6] configure: Fix ppc container_cross_cc substitution, Paolo Bonzini, 2022/07/29
- [PULL 6/6] configure: pass correct cflags to container-based cross compilers, Paolo Bonzini, 2022/07/29
- [PULL 5/6] kvm: don't use perror() without useful errno,
Paolo Bonzini <=
- [PULL 3/6] stubs: update replay-tools to match replay.h types, Paolo Bonzini, 2022/07/29
- Re: [PULL 0/6] Fixes for QEMU 7.1-rc1, Richard Henderson, 2022/07/29