[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 08/14] KVM: Rename mmu_notifier_*
From: |
Sean Christopherson |
Subject: |
Re: [PATCH v7 08/14] KVM: Rename mmu_notifier_* |
Date: |
Fri, 29 Jul 2022 19:02:12 +0000 |
On Wed, Jul 06, 2022, Chao Peng wrote:
> The sync mechanism between mmu_notifier and page fault handler employs
> fields mmu_notifier_seq/count and mmu_notifier_range_start/end. For the
> to be added private memory, there is the same mechanism needed but not
> rely on mmu_notifier (It uses new introduced memfile_notifier). This
> patch renames the existing fields and related helper functions to a
> neutral name mmu_updating_* so private memory can reuse.
mmu_updating_* is too broad of a term, e.g. page faults and many other
operations
also update the mmu. Although the name most definitely came from the
mmu_notifier,
it's not completely inaccurate for other sources, e.g. KVM's MMU is still being
notified of something, even if the source is not the actual mmu_notifier.
If we really want a different name, I'd vote for nomenclature that captures the
invalidation aspect, which is really what the variables are all trackng, e.g.
mmu_invalidate_seq
mmu_invalidate_in_progress
mmu_invalidate_range_start
mmu_invalidate_range_end
- [PATCH v7 02/14] selftests/memfd: Add tests for F_SEAL_AUTO_ALLOCATE, (continued)
- [PATCH v7 02/14] selftests/memfd: Add tests for F_SEAL_AUTO_ALLOCATE, Chao Peng, 2022/07/06
- [PATCH v7 03/14] mm: Introduce memfile_notifier, Chao Peng, 2022/07/06
- [PATCH v7 04/14] mm/shmem: Support memfile_notifier, Chao Peng, 2022/07/06
- Re: [PATCH v7 04/14] mm/shmem: Support memfile_notifier, Gupta, Pankaj, 2022/07/12
- Re: [PATCH v7 04/14] mm/shmem: Support memfile_notifier, Chao Peng, 2022/07/13
- Re: [PATCH v7 04/14] mm/shmem: Support memfile_notifier, Gupta, Pankaj, 2022/07/13
- Re: [PATCH v7 04/14] mm/shmem: Support memfile_notifier, Chao Peng, 2022/07/13
- Re: [PATCH v7 04/14] mm/shmem: Support memfile_notifier, Gupta, Pankaj, 2022/07/14
[PATCH v7 05/14] mm/memfd: Introduce MFD_INACCESSIBLE flag, Chao Peng, 2022/07/06
[PATCH v7 08/14] KVM: Rename mmu_notifier_*, Chao Peng, 2022/07/06
- Re: [PATCH v7 08/14] KVM: Rename mmu_notifier_*,
Sean Christopherson <=
[PATCH v7 06/14] KVM: Rename KVM_PRIVATE_MEM_SLOTS to KVM_INTERNAL_MEM_SLOTS, Chao Peng, 2022/07/06
[PATCH v7 07/14] KVM: Use gfn instead of hva for mmu_notifier_retry, Chao Peng, 2022/07/06
[PATCH v7 11/14] KVM: Register/unregister the guest private memory regions, Chao Peng, 2022/07/06