Re: [PATCH 12/51] tests: Use g_mkdir_with_parents()

[Bin Meng]

On Thu, Aug 25, 2022 at 1:58 AM Dr. David Alan Gilbert
<dgilbert@redhat.com> wrote:
>
> * Bin Meng (bmeng.cn@gmail.com) wrote:
> > From: Bin Meng <bin.meng@windriver.com>
> >
> > Use the same g_mkdir_with_parents() call to create a directory on
> > all platforms.
> >
> > Signed-off-by: Bin Meng <bin.meng@windriver.com>
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> > ---
> >
> >  tests/migration/stress.c              | 2 +-
> >  tests/qtest/migration-test.c          | 6 +++---
> >  tests/unit/test-crypto-tlscredsx509.c | 4 ++--
> >  tests/unit/test-crypto-tlssession.c   | 6 +++---
> >  tests/unit/test-io-channel-tls.c      | 6 +++---
> >  5 files changed, 12 insertions(+), 12 deletions(-)
> >

The exact portable replacement for mkdir() in glib is g_mkdir(), not
g_mkdir_with_parents().

I was misled by the GTK glib doc [1] before. I will change it to
g_mkdir() in v2 instead.

[1] https://docs.gtk.org/glib/?q=mkdir

Regards,
Bin