Re: [PATCH v7 05/20] linux-user: Clear translations and tb_jmp_cache on mprotect()

[Richard Henderson]

On 8/31/22 00:17, Ilya Leoshkevich wrote:
> >       page_set_flags(start, start + len, page_flags);
> > +    tb_invalidate_phys_range(start, start + len);
> > +
> > +    CPU_FOREACH(cpu) {
> > +        cpu_tb_jmp_cache_clear(cpu);
> > +    }
> > +
> >       mmap_unlock();
> >       return 0;
> >   error:
>
> I think adding tb_invalidate_phys_range() obviates the need for
> cpu_tb_jmp_cache_clear()? The lookup may still find an invalidated tb,
> but it will have CF_INVALID set.

Quite right.  And we definitely don't want to have to touch a list of all threads if its 
not necessary.


r~