|
From: | Richard Henderson |
Subject: | Re: [PATCH v3 10/23] i386: do not cast gen_helper_* function pointers |
Date: | Thu, 1 Sep 2022 09:10:51 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 |
On 9/1/22 08:48, Paolo Bonzini wrote:
#define OP(op, flags, a, b, c, d) \ - {flags, {a, b, c, d} } + {flags, {{.op = a}, {.op = b}, {.op = c}, {.op = d} } }
It would have been handy to have uppercase macro args here, because .op looks like...
struct SSEOpHelper_table1 { int flags; - SSEFunc_0_epp op[4]; + SSEFuncs fn[4]; };
... a forgotten change to .fn at first glance.
#define OP(name, op, flags, ext, mmx_name) \ - {{mmx_name, gen_helper_ ## name ## _xmm}, CPUID_EXT_ ## ext, flags} + {{{.op = mmx_name}, {.op = gen_helper_ ## name ## _xmm} }, \ + CPUID_EXT_ ## ext, flags}
Likewise. But either way, Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
[Prev in Thread] | Current Thread | [Next in Thread] |