qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 15/23] i386: Destructive vector helpers for AVX


From: Richard Henderson
Subject: Re: [PATCH v3 15/23] i386: Destructive vector helpers for AVX
Date: Thu, 1 Sep 2022 09:16:23 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 9/1/22 08:48, Paolo Bonzini wrote:
From: Paul Brook<paul@nowt.org>

These helpers need to take special care to avoid overwriting source values
before the wole result has been calculated.  Currently they use a dummy
Reg typed variable to store the result then assign the whole register.
This will cause 128 bit operations to corrupt the upper half of the register,
so replace it with explicit temporaries and element assignments.

Signed-off-by: Paul Brook<paul@nowt.org>
Message-Id:<20220424220204.2493824-14-paul@nowt.org>
Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
---
  target/i386/ops_sse.h | 556 ++++++++++++++++++++----------------------
  1 file changed, 262 insertions(+), 294 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]