[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/10] hw/arm/virt: Fix devicetree warnings about the GIC nod
From: |
Jean-Philippe Brucker |
Subject: |
Re: [PATCH 03/10] hw/arm/virt: Fix devicetree warnings about the GIC node |
Date: |
Thu, 1 Sep 2022 15:55:13 +0100 |
On Wed, Aug 24, 2022 at 08:36:33PM +0100, Peter Maydell wrote:
> On Wed, 24 Aug 2022 at 16:51, Jean-Philippe Brucker
> <jean-philippe@linaro.org> wrote:
> >
> > Fix three dt-validate warnings about the GIC node due to invalid names
> > and missing property:
> >
> > intc@8000000: $nodename:0: 'intc@8000000' does not match
> > '^interrupt-controller(@[0-9a-f,]+)*$'
> > intc@8000000: 'its@8080000' does not match any of the regexes:
> > '^(msi-controller|gic-its|interrupt-controller)@[0-9a-f]+$', '^gic-its@',
> > '^interrupt-controller@[0-9a-f]+$', 'pinctrl-[0-9]+'
> >
> > interrupt-controller@8000000: msi-controller@8080000: '#msi-cells' is a
> > required property
> > From schema:
> > linux/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml
>
> Why is dt-validate complaining about the node names? Surely
> anything looking for the ITS in the DT should be looking for
> it by the "compatible" string ?
The device-tree specification, in 2.2.2 Generic Name Recommendation [1],
provides the node names. Given that the guest will look at compatible
strings, changing the name is safe.
Thanks,
Jean
[1]
http://devicetree-org.github.io/devicetree-specification/index.html#generic-names-recommendation
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 03/10] hw/arm/virt: Fix devicetree warnings about the GIC node,
Jean-Philippe Brucker <=