|
From: | Hyman Huang |
Subject: | Re: [PATCH v1 2/8] qapi/migration: Introduce x-vcpu-dirty-limit parameters |
Date: | Fri, 2 Sep 2022 21:27:33 +0800 |
User-agent: | Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 |
在 2022/9/2 16:03, Markus Armbruster 写道:
huangy81@chinatelecom.cn writes:From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn> Introduce "x-vcpu-dirty-limit" migration parameter used to limit dirty page rate during live migration. "x-vcpu-dirty-limit" and "x-vcpu-dirty-limit-period" are two dirty-limit-related migration parameters, which can be set before and during live migration by qmp migrate-set-parameters. This two parameters are used to help implement the dirty page rate limit algo of migration. Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>[...]diff --git a/qapi/migration.json b/qapi/migration.json index 332c087..8554d33 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -779,6 +779,9 @@ # @x-vcpu-dirty-limit-period: Periodic time (ms) of dirty limit during live migration. # Defaults to 500ms. (Since 7.1) # +# @x-vcpu-dirty-limit: Dirtyrate limit (MB/s) during live migration. +# Defaults to 1. (Since 7.1) +# # Features: # @unstable: Member @x-checkpoint-delay and @x-vcpu-dirty-limit-period # are experimental. @@ -801,7 +804,8 @@ 'max-cpu-throttle', 'multifd-compression', 'multifd-zlib-level', 'multifd-zstd-level', 'block-bitmap-mapping', - { 'name': 'x-vcpu-dirty-limit-period', 'features': ['unstable'] } ] } + { 'name': 'x-vcpu-dirty-limit-period', 'features': ['unstable'] }, + 'x-vcpu-dirty-limit'] }Shouldn't 'x-vcpu-dirty-limit-period' have feature 'unstable', too?
Yes, i missed that, thanks very much.
Same below.### @MigrateSetParameters: @@ -949,6 +953,9 @@ # @x-vcpu-dirty-limit-period: Periodic time (ms) of dirty limit during live migration. # Defaults to 500ms. (Since 7.1) # +# @x-vcpu-dirty-limit: Dirtyrate limit (MB/s) during live migration. +# Defaults to 1. (Since 7.1) +# # Features: # @unstable: Member @x-checkpoint-delay and @x-vcpu-dirty-limit-period # are experimental. @@ -987,7 +994,8 @@ '*multifd-zstd-level': 'uint8', '*block-bitmap-mapping': [ 'BitmapMigrationNodeAlias' ], '*x-vcpu-dirty-limit-period': { 'type': 'uint64', - 'features': [ 'unstable' ] } } } + 'features': [ 'unstable' ] }, + '*x-vcpu-dirty-limit': 'uint64'} }### @migrate-set-parameters: @@ -1155,6 +1163,9 @@ # @x-vcpu-dirty-limit-period: Periodic time (ms) of dirty limit during live migration. # Defaults to 500ms. (Since 7.1) # +# @x-vcpu-dirty-limit: Dirtyrate limit (MB/s) during live migration. +# Defaults to 1. (Since 7.1) +# # Features: # @unstable: Member @x-checkpoint-delay and @x-vcpu-dirty-limit-period # are experimental. @@ -1191,7 +1202,8 @@ '*multifd-zstd-level': 'uint8', '*block-bitmap-mapping': [ 'BitmapMigrationNodeAlias' ], '*x-vcpu-dirty-limit-period': { 'type': 'uint64', - 'features': [ 'unstable' ] } } } + 'features': [ 'unstable' ] }, + '*x-vcpu-dirty-limit': 'uint64'} }### @query-migrate-parameters:
-- Best regard Hyman Huang(黄勇)
[Prev in Thread] | Current Thread | [Next in Thread] |