Re: [PATCH 02/20] ppc4xx: Introduce Ppc4xxSdramBank struct

[Philippe Mathieu-Daudé]

On 19/8/22 18:55, BALATON Zoltan wrote:
> Instead of storing sdram bank parameters in unrelated arrays put them
> in a struct so it's clear they belong to the same bank and simplify
> the state struct using this bank type.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>   hw/ppc/ppc440_uc.c      | 49 +++++++++++++++++-----------------
>   hw/ppc/ppc4xx_devs.c    | 59 ++++++++++++++++++++---------------------
>   include/hw/ppc/ppc4xx.h |  8 ++++++
>   3 files changed, 61 insertions(+), 55 deletions(-)

Good idea!
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>