qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] softmmu/physmem: Fix address of FlatView access in address_s


From: Alberto Campinho Faria
Subject: Re: [PATCH] softmmu/physmem: Fix address of FlatView access in address_space_(read|write)_cached_slow()
Date: Mon, 5 Sep 2022 00:32:40 +0100

Hi Peter,

On Sat, Aug 27, 2022 at 7:59 PM Peter Xu <peterx@redhat.com> wrote:
> Any bug encountered?  It'll be great to add more information into the
> commit message if there is.  We could also mention the issue was observed
> by code review or so.

I came across this when performing unaligned 8-byte writes on
x86_64-softmmu. The write was aligned to 4 bytes but not 8, so the
first 4 bytes were written just fine by
address_space_translate_cached(), but flatview_write_continue() failed
to write the following 4 bytes as it was translating the wrong
address. I'll mention this in the commit description.

Thanks,
Alberto




reply via email to

[Prev in Thread] Current Thread [Next in Thread]