[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 02/20] disas/nanomips: Extract enums out of the NMD class
From: |
Milica Lazarevic |
Subject: |
[PATCH v2 02/20] disas/nanomips: Extract enums out of the NMD class |
Date: |
Mon, 5 Sep 2022 11:55:04 +0200 |
Definitions of enums TABLE_ENTRY_TYPE and TABLE_ATTRIBUTE_TYPE are moved
out of the NMD class. The main goal is to remove NMD class completely.
Signed-off-by: Milica Lazarevic <milica.lazarevic@syrmia.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
disas/nanomips.cpp | 8 +++----
disas/nanomips.h | 59 +++++++++++++++++++++++-----------------------
2 files changed, 33 insertions(+), 34 deletions(-)
diff --git a/disas/nanomips.cpp b/disas/nanomips.cpp
index 84529685bf..bdc640b38b 100644
--- a/disas/nanomips.cpp
+++ b/disas/nanomips.cpp
@@ -50,8 +50,8 @@ int nanomips_dis(char *buf,
std::string disasm;
uint16 bits[3] = {one, two, three};
- NMD::TABLE_ENTRY_TYPE type;
- NMD d(address, NMD::ALL_ATTRIBUTES);
+ TABLE_ENTRY_TYPE type;
+ NMD d(address, ALL_ATTRIBUTES);
int size = d.Disassemble(bits, disasm, type);
strcpy(buf, disasm.c_str());
@@ -772,7 +772,7 @@ uint64 NMD::extract_op_code_value(const uint16 * data, int
size)
int NMD::Disassemble(const uint16 * data, std::string & dis,
- NMD::TABLE_ENTRY_TYPE & type)
+ TABLE_ENTRY_TYPE & type)
{
return Disassemble(data, dis, type, MAJOR, 2);
}
@@ -790,7 +790,7 @@ int NMD::Disassemble(const uint16 * data, std::string & dis,
* disassembly string - on error will constain error string
*/
int NMD::Disassemble(const uint16 * data, std::string & dis,
- NMD::TABLE_ENTRY_TYPE & type, const Pool *table,
+ TABLE_ENTRY_TYPE & type, const Pool *table,
int table_size)
{
try
diff --git a/disas/nanomips.h b/disas/nanomips.h
index 9fe0cc67da..f65a0957b8 100644
--- a/disas/nanomips.h
+++ b/disas/nanomips.h
@@ -31,41 +31,40 @@ typedef uint32_t uint32;
typedef uint16_t uint16;
typedef uint64_t img_address;
+enum TABLE_ENTRY_TYPE {
+ instruction,
+ call_instruction,
+ branch_instruction,
+ return_instruction,
+ reserved_block,
+ pool,
+};
+
+enum TABLE_ATTRIBUTE_TYPE {
+ MIPS64_ = 0x00000001,
+ XNP_ = 0x00000002,
+ XMMS_ = 0x00000004,
+ EVA_ = 0x00000008,
+ DSP_ = 0x00000010,
+ MT_ = 0x00000020,
+ EJTAG_ = 0x00000040,
+ TLBINV_ = 0x00000080,
+ CP0_ = 0x00000100,
+ CP1_ = 0x00000200,
+ CP2_ = 0x00000400,
+ UDI_ = 0x00000800,
+ MCU_ = 0x00001000,
+ VZ_ = 0x00002000,
+ TLB_ = 0x00004000,
+ MVH_ = 0x00008000,
+ ALL_ATTRIBUTES = 0xffffffffull,
+};
+
class NMD
{
public:
- enum TABLE_ENTRY_TYPE {
- instruction,
- call_instruction,
- branch_instruction,
- return_instruction,
- reserved_block,
- pool,
- };
-
- enum TABLE_ATTRIBUTE_TYPE {
- MIPS64_ = 0x00000001,
- XNP_ = 0x00000002,
- XMMS_ = 0x00000004,
- EVA_ = 0x00000008,
- DSP_ = 0x00000010,
- MT_ = 0x00000020,
- EJTAG_ = 0x00000040,
- TLBINV_ = 0x00000080,
- CP0_ = 0x00000100,
- CP1_ = 0x00000200,
- CP2_ = 0x00000400,
- UDI_ = 0x00000800,
- MCU_ = 0x00001000,
- VZ_ = 0x00002000,
- TLB_ = 0x00004000,
- MVH_ = 0x00008000,
- ALL_ATTRIBUTES = 0xffffffffull,
- };
-
-
NMD(img_address pc, TABLE_ATTRIBUTE_TYPE requested_instruction_categories)
: m_pc(pc)
, m_requested_instruction_categories(requested_instruction_categories)
--
2.25.1
- [PATCH v2 0/20] Convert nanoMIPS disassembler from C++ to C, Milica Lazarevic, 2022/09/05
- [PATCH v2 01/20] disas/nanomips: Remove namespace img, Milica Lazarevic, 2022/09/05
- [PATCH v2 02/20] disas/nanomips: Extract enums out of the NMD class,
Milica Lazarevic <=
- [PATCH v2 05/20] disas/nanomips: Remove __cond methods from class, Milica Lazarevic, 2022/09/05
- [PATCH v2 03/20] disas/nanomips: Delete NMD class fields, Milica Lazarevic, 2022/09/05
- [PATCH v2 04/20] disas/nanomips: Remove helper methods from class, Milica Lazarevic, 2022/09/05
- [PATCH v2 06/20] disas/nanomips: Remove disasm methods from class, Milica Lazarevic, 2022/09/05