[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 18/20] disas/nanomips: Remove argument passing by ref
From: |
Milica Lazarevic |
Subject: |
[PATCH v2 18/20] disas/nanomips: Remove argument passing by ref |
Date: |
Mon, 5 Sep 2022 11:55:20 +0200 |
Replaced argument passing by reference with passing by address.
Signed-off-by: Milica Lazarevic <milica.lazarevic@syrmia.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
disas/nanomips.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/disas/nanomips.cpp b/disas/nanomips.cpp
index f57d255de3..ab54456c2e 100644
--- a/disas/nanomips.cpp
+++ b/disas/nanomips.cpp
@@ -635,7 +635,7 @@ static uint64 extract_op_code_value(const uint16 *data, int
size)
* disassembly string - on error will constain error string
*/
static int Disassemble(const uint16 *data, char *dis,
- TABLE_ENTRY_TYPE & type, const Pool *table,
+ TABLE_ENTRY_TYPE *type, const Pool *table,
int table_size, struct Dis_info *info)
{
for (int i = 0; i < table_size; i++) {
@@ -669,7 +669,7 @@ static int Disassemble(const uint16 *data, char *dis,
"disassembler failure - bad table entry");
return -6;
}
- type = table[i].type;
+ *type = table[i].type;
g_autofree char *dis_str = dis_fn(op_code, info);
strcpy(dis, dis_str);
return table[i].instructions_size;
@@ -22248,7 +22248,7 @@ static int nanomips_dis(char *buf,
uint16 bits[3] = {one, two, three};
TABLE_ENTRY_TYPE type;
- int size = Disassemble(bits, disasm, type, MAJOR, 2, info);
+ int size = Disassemble(bits, disasm, &type, MAJOR, 2, info);
strcpy(buf, disasm);
return size;
--
2.25.1
- Re: [PATCH v2 12/20] disas/nanomips: Replace std::string type, (continued)
- [PATCH v2 13/20] disas/nanomips: Prevent memory leaking, Milica Lazarevic, 2022/09/05
- [PATCH v2 14/20] disas/nanomips: Remove function overloading, Milica Lazarevic, 2022/09/05
- [PATCH v2 15/20] disas/nanomips: Introduce Dis_info struct, Milica Lazarevic, 2022/09/05
- [PATCH v2 16/20] disas/nanomips: Replace exception handling, Milica Lazarevic, 2022/09/05
- [PATCH v2 18/20] disas/nanomips: Remove argument passing by ref,
Milica Lazarevic <=
- [PATCH v2 17/20] disas/nanomips: Replace Cpp enums for C enums, Milica Lazarevic, 2022/09/05
- [PATCH v2 19/20] disas/nanomips: Add struct keyword, Milica Lazarevic, 2022/09/05
- [PATCH v2 20/20] disas/nanomips: Rename nanomips.cpp to nanomips.c, Milica Lazarevic, 2022/09/05