qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 05/20] disas/nanomips: Remove __cond methods from class


From: Richard Henderson
Subject: Re: [PATCH v2 05/20] disas/nanomips: Remove __cond methods from class
Date: Mon, 5 Sep 2022 12:06:22 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 9/5/22 10:55, Milica Lazarevic wrote:
NMD class methods with the conditional_function type like
NMD::ADDIU_32__cond, NMD::ADDIU_RS5__cond, etc. are removed from the NMD
class. They're now declared global static functions. Therefore, typedef
of the function pointer, conditional_function is defined outside of the
class.

Now that conditional_function type functions are not part of the NMD
class we can't access them using the this pointer. Thus, the use of
the this pointer has been deleted.

Signed-off-by: Milica Lazarevic<milica.lazarevic@syrmia.com>
Reviewed-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
---
  disas/nanomips.cpp | 42 +++++++++++++++++++++---------------------
  disas/nanomips.h   | 14 ++------------
  2 files changed, 23 insertions(+), 33 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]