qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 07/20] disas/nanomips: Remove Pool tables from the class


From: Richard Henderson
Subject: Re: [PATCH v2 07/20] disas/nanomips: Remove Pool tables from the class
Date: Mon, 5 Sep 2022 12:11:13 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 9/5/22 10:55, Milica Lazarevic wrote:
Pool tables are no longer declared as static fields of the NMD
class but as global static variables.

The NMD::Disassemble method is using the MAJOR Pool table variable, so
its implementation is moved to the end of the nanomips.cpp file,
right after the initialization of the MAJOR Pool table.

Signed-off-by: Milica Lazarevic<milica.lazarevic@syrmia.com>
Reviewed-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
---
  disas/nanomips.cpp | 363 ++++++++++++++++++++++-----------------------
  disas/nanomips.h   | 200 ++-----------------------
  2 files changed, 193 insertions(+), 370 deletions(-)

It would be nice if all of these were const. That might require a separate patch in order to add const to users, or it might not.

Either way, this patch is fine,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]