qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 0/2] introduce qemu_socketpiar()


From: Guoyi Tu
Subject: Re: [PATCH v1 0/2] introduce qemu_socketpiar()
Date: Mon, 5 Sep 2022 20:27:51 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0



On 9/5/22 19:19, Marc-André Lureau wrote:
Hi

On Tue, Aug 23, 2022 at 12:00 PM <tugy@chinatelecom.cn <mailto:tugy@chinatelecom.cn>> wrote:

    From: Guoyi Tu <tugy@chinatelecom.cn <mailto:tugy@chinatelecom.cn>>

    Introduce qemu_socketpair() to create socket pair fd, and
    set the close-on-exec flag at default as with the other type
    of socket does.

    besides, the live update feature is developing, so it's necessary
    to do that.

    Guoyi Tu (2):
       oslib-posix: Introduce qemu_socketpair()
       vhost-user: Call qemu_socketpair() instead of socketpair()


Looks like a good idea to me. We will eventually extend the support for win32 (as discussed in "[PATCH 19/51] tests/qtest: Build test-filter-{mirror, redirector} cases for posix only").

There are other places where you can replace existing socketpair() calls in the code base. Why not do it?

yeah, Thanks for reminding me, Maybe i can replace all the existing socketpair() calls in a separate patch if this patch can be merged to upstream.

--
Guoyi

Current patches lgtm
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com <mailto:marcandre.lureau@redhat.com>>

--
Marc-André Lureau



reply via email to

[Prev in Thread] Current Thread [Next in Thread]