Re: [PATCH 3/3] target/ppc: Merge fsqrt and fsqrts helpers

[Richard Henderson]

On 9/5/22 17:19, Víctor Colombo wrote:
> > Existing bug, but this is missing to clear fp status to start.
> >
> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> >
> > r~
>
> Hello Richard, thanks for your review!
> gen_reset_fpstatus() is called by the inline implementation in
> do_helper_fsqrt() before calling the helper (patch 1).

Oops, ok.


> It's probably better to move the call to inside the helper.

I did write about a scheme by which all of these calls should go away.  I guess it has 
been a while...


r~