qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 10/19] target/ppc: Clear fpstatus flags on VSX_CVT_FP_TO_FP


From: Daniel Henrique Barboza
Subject: Re: [PATCH 10/19] target/ppc: Clear fpstatus flags on VSX_CVT_FP_TO_FP
Date: Mon, 5 Sep 2022 15:32:01 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0



On 9/1/22 10:17, Víctor Colombo wrote:
Signed-off-by: Víctor Colombo <victor.colombo@eldorado.org.br>
---

IIUC all the changes from patches 8-10 are based on the logic explained
in the commit message of patch 08. Problem is that patches 9 and 10 are
lacking context per themselves.

I'd rather either have patches 9 and 10 squashed into patch 8, or patches
9 and 10 need more meat in their commit messages.


Thanks,


Daniel

  target/ppc/fpu_helper.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/target/ppc/fpu_helper.c b/target/ppc/fpu_helper.c
index ceb70ed36e..8a20413a78 100644
--- a/target/ppc/fpu_helper.c
+++ b/target/ppc/fpu_helper.c
@@ -2692,6 +2692,8 @@ void helper_##op(CPUPPCState *env, ppc_vsr_t *xt, 
ppc_vsr_t *xb)   \
      ppc_vsr_t t = { };                                             \
      int i;                                                         \
                                                                     \
+    helper_reset_fpstatus(env);                                    \
+                                                                   \
      for (i = 0; i < nels; i++) {                                   \
          t.tfld = stp##_to_##ttp(xb->sfld, &env->fp_status);        \
          if (unlikely(stp##_is_signaling_nan(xb->sfld,              \



reply via email to

[Prev in Thread] Current Thread [Next in Thread]