Re: [PATCH v3 6/6] include/exec: Introduce TARGET_PAGE_ENTRY_EXTRA

[Richard Henderson]

On 9/5/22 22:28, Philippe Mathieu-Daudé wrote:
> > +    /*
> > +     * Allow target-specific additions to this structure.
> > +     * This may be used to cache items from the guest cpu
> > +     * page tables for later use by the implementation.
> > +     */
> > +#ifdef TARGET_PAGE_ENTRY_EXTRA
> > +    TARGET_PAGE_ENTRY_EXTRA
> > +#endif
> >   } CPUTLBEntryFull;
>
> Alternatively declare a per-target structure in cpu-param.h
> and here:
>
> typedef struct CPUTLBEntryTarget CPUTLBEntryTarget;
>
> #ifndef TARGET_HAS_PAGE_ENTRY_EXTRA_STRUCT
> struct CPUTLBEntryTarget { }
> #endif

This was v1, more or less,
https://lore.kernel.org/qemu-devel/20220703082419.770989-2-richard.henderson@linaro.org/

In the end I thought the "extra" part confusing.
I was also concerned that I might be introducing
extra structure padding unnecessarily.


r~