[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC] module: removed unused function argument "mayfail"
From: |
Claudio Fontana |
Subject: |
Re: [RFC] module: removed unused function argument "mayfail" |
Date: |
Tue, 6 Sep 2022 10:20:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 |
On 9/5/22 22:55, Philippe Mathieu-Daudé wrote:
> On 5/9/22 17:55, Claudio Fontana wrote:
>> mayfail is always passed as false for every invocation throughout the
>> program.
>> It controls whether to printf or not to printf an error on
>> g_module_open failure.
>>
>> Remove this unused argument.
>>
>> Signed-off-by: Claudio Fontana <cfontana@suse.de>
>> ---
>> include/qemu/module.h | 8 ++++----
>> softmmu/qtest.c | 2 +-
>> util/module.c | 20 +++++++++-----------
>> 3 files changed, 14 insertions(+), 16 deletions(-)
>
> Why RFC?
Maybe there was some obscure way the parameter was intended to be used by
someone, somewhere :-)
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Ciao,
C