Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

[Daniel P . Berrangé]

On Tue, Jul 12, 2022 at 12:45:59PM +0530, Ani Sinha wrote:
> 
> 
> On Mon, 11 Jul 2022, John Snow wrote:
> 
> > On Sun, Jul 10, 2022 at 1:01 PM Ani Sinha <ani@anisinha.ca> wrote:
> > >
> > > This change adds python based test environment that can be used to run 
> > > pytest
> > > from within a virtual environment. A bash script sets up a virtual 
> > > environment
> > > and then runs the python based tests from within that environment.
> > > All dependent python packages are installed in the virtual environment 
> > > using
> > > pip python module. QEMU python test modules are also available in the 
> > > environment
> > > for spawning the QEMU based VMs.
> > >
> > > It also introduces QEMU acpi/smbios biosbits python test script which is 
> > > run
> > > from within the python virtual environment. When the bios bits tests are 
> > > run,
> > > bios bits binaries are downloaded from an external repo/location.
> > > Currently, the test points to an external private github repo where the 
> > > bits
> > > archives are checked in.
> > >
> >
> > Oh, I see -- requirements are handled here in this patch.
> >
> > Is this test designed to run the host/build system? I'm a little
> > confused about the environment here.
> 
> yes it is supposed to run on the build system where "make check" is
> executed.
> 
> >
> > Is this test going to be run "by default" or will users have to opt
> > into running it using a special invocation?
> 
> run by default through "make check" or "make check-pytest" or "make
> check-pytest-x86_64".

I don't think that a default 'make check' should be downloading
disk images, especially when they're stored in the local build
dir by default and so lost when the build dir is cleaned.

The downloading of disk images is one of the reasons why avocado
is not set to run by default with 'make check', and I think this
should be the same. This again takes me to back to believing that
we should simply be using Avocado here instead of creating something
that has to solve the same problems.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|