qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] audio: add help option (?) for -audiodev


From: BALATON Zoltan
Subject: Re: [PATCH] audio: add help option (?) for -audiodev
Date: Wed, 7 Sep 2022 18:07:25 +0200 (CEST)

On Wed, 7 Sep 2022, Daniel P. Berrangé wrote:
On Wed, Sep 07, 2022 at 05:06:36PM +0200, Markus Armbruster wrote:
Claudio Fontana <cfontana@suse.de> writes:

add a simple help option for -audiodev, so users can do

qemu -audiodev ?

The preferred form is actually '-audiodev help'.  The other one is
deprecated.  Recommend to stay away from it even in commit messages.

We introduced 'help' many many years ago, but don't thing we
ever formally deprecated '?'.  Should we do so and aim to
remove it, or are we happy to keep '?' forever, despite it
tripping up shell filename expansion with single char filenames.

Had this conversation before and I think we agreed to keep ? as a convenient shorthand even if help is preferred so it should not be deprecated but you can keep it from appearing in docs to advertise help as the preferred option. (\? is still shorter to type than help if you're worried about shell expansion which is rarely a problem in practice)

Regards,
BALATON Zoltan

(tangential to this patch, NOT a request to fix something in v2)


to get the list of drivers available.

Signed-off-by: Claudio Fontana <cfontana@suse.de>
---
 audio/audio.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

Update qemu-options.hx ?


With regards,
Daniel

reply via email to

[Prev in Thread] Current Thread [Next in Thread]