[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Use QMP command object-add instead of object_add for memory
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH] Use QMP command object-add instead of object_add for memory hotplugin |
Date: |
Thu, 8 Sep 2022 13:55:49 +0100 |
User-agent: |
Mutt/2.2.6 (2022-06-05) |
* Markus Armbruster (armbru@redhat.com) wrote:
> liuhaiwei9699 <liuhaiwei9699@126.com> writes:
>
> > why the hmp using the object_add , qmp using the object-add command?
> > can't we use the same command ?
>
> Command names differ between HMP and QMP for historical reasons.
>
> QMP is a stable interface, and changing names there is no go.
>
> HMP is not a stable interface, but changing names would still
> inconvenience users. We don't do that without really compelling
> reasons.
>
> I think HMP could fold '_' and '-' together in command names, so that
> both object_add and object-add work. Best to check with the HMP
> maintainer before you start coding.
Yes, I'd be up for having folding on _/- - I never remember which I need
in any case.
Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK