Re: [PATCH v3] audio: Add sndio backend

[Volker Rümelin]

Am 07.09.22 um 15:23 schrieb Alexandre Ratchov:
> sndio is the native API used by OpenBSD, although it has been ported to
> other *BSD's and Linux (packages for Ubuntu, Debian, Void, Arch, etc.).
>
> Signed-off-by: Brad Smith<brad@comstyle.com>
> Signed-off-by: Alexandre Ratchov<alex@caoua.org>
> ---
>
> References to the previous patch versions and related discussions are
> here:
>
> https://marc.info/?l=qemu-devel&m=163973393011543   (v2)
> https://marc.info/?l=qemu-devel&m=163626248712444   (initial patch)
>
> Here are the changes between v2 and v3 of this patch:
>
> - fixed of typos in file-names in MAINTAINERS
> - added Gerd Hoffmann to the M: entry in MAINTAINERS
> - added missin S: entry in MAINTAINERS
> - removed unused #include "qemu-common.h"
> - bumped "Since:" version to 7.2 in qapi/audio.json
> - regenerated scripts/meson-buildoptions.sh
> - implement buffer_get_free() method, introduced by
>    commit 9833438ef624155de879d4ed57ecfcd3464a0bbe
>
>    audio: restore mixing-engine playback buffer size
>
> Running "make update-buildoptions" triggered unrelated changes of
> scripts/meson-buildoptions.sh, that I removed from the commit as they
> are not related to sndio.
>
> Tested on OpenBSD, still works as expected :-)
>
> Regards,
> Alexandre
>
>   MAINTAINERS                   |   7 +
>   audio/audio.c                 |   1 +
>   audio/audio_template.h        |   2 +
>   audio/meson.build             |   1 +
>   audio/sndioaudio.c            | 565 ++++++++++++++++++++++++++++++++++
>   meson.build                   |   9 +-
>   meson_options.txt             |   4 +-
>   qapi/audio.json               |  25 +-
>   qemu-options.hx               |  16 +
>   scripts/meson-buildoptions.sh |   7 +-
>   10 files changed, 632 insertions(+), 5 deletions(-)
>   create mode 100644 audio/sndioaudio.c

Tested again on Linux.

Reviewed-by: Volker Rümelin <vr_qemu@t-online.de>
Tested-by: Volker Rümelin <vr_qemu@t-online.de>