qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/7] .gitlab-ci.d/windows.yml: Drop the sed processing in the


From: Thomas Huth
Subject: Re: [PATCH 4/7] .gitlab-ci.d/windows.yml: Drop the sed processing in the 64-bit build
Date: Fri, 9 Sep 2022 18:30:13 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0

On 08/09/2022 16.04, Marc-André Lureau wrote:
Hi

On Thu, Sep 8, 2022 at 5:33 PM Bin Meng <bmeng.cn@gmail.com <mailto:bmeng.cn@gmail.com>> wrote:

    From: Bin Meng <bin.meng@windriver.com <mailto:bin.meng@windriver.com>>

    The sed processing of build/config-host.mak seems to be no longer
    needed, and there is no such in the 32-bit build too. Drop it.

    Signed-off-by: Bin Meng <bin.meng@windriver.com
    <mailto:bin.meng@windriver.com>>
    ---

      .gitlab-ci.d/windows.yml | 1 -
      1 file changed, 1 deletion(-)

    diff --git a/.gitlab-ci.d/windows.yml b/.gitlab-ci.d/windows.yml
    index da6013904a..86a4339c48 100644
    --- a/.gitlab-ci.d/windows.yml
    +++ b/.gitlab-ci.d/windows.yml
    @@ -60,7 +60,6 @@ msys2-64bit:
        - $env:MSYS = 'winsymlinks:native' # Enable native Windows symlink
        - .\msys64\usr\bin\bash -lc './configure --target-list=x86_64-softmmu
            --enable-capstone --without-default-devices'
    -  - .\msys64\usr\bin\bash -lc "sed -i '/^ROMS=/d' build/config-host.mak"


It looks like it is there to remove the ROMS from the make build. No idea if that still makes sense. Thomas, do you remember?

I originally had to add this sed statement since there was a compile error otherwise in the ROMS ... if it now works fine without this line, this should be fine, of course, too.

Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]