Re: [PATCH 3/4] python/qmp: increase read buffer size

[Vladimir Sementsov-Ogievskiy]

On 9/8/22 13:36, Maksim Davydov wrote:
> After modification of "query-machines" command the buffer size should be
> more than 452kB to contain output with compat-props.
>
> Signed-off-by: Maksim Davydov <davydov-max@yandex-team.ru>
> ---
>   python/qemu/qmp/qmp_client.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/python/qemu/qmp/qmp_client.py b/python/qemu/qmp/qmp_client.py
> index 5dcda04a75..659fe4d98c 100644
> --- a/python/qemu/qmp/qmp_client.py
> +++ b/python/qemu/qmp/qmp_client.py
> @@ -197,8 +197,8 @@ async def run(self, address='/tmp/qemu.socket'):
>       #: Logger object used for debugging messages.
>       logger = logging.getLogger(__name__)
>   
> -    # Read buffer limit; large enough to accept query-qmp-schema
> -    _limit = (256 * 1024)
> +    # Read buffer limit; large enough to accept query-machines
> +    _limit = (512 * 1024)
>   
>       # Type alias for pending execute() result items
>       _PendingT = Union[Message, ExecInterruptedError]


Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

This patch should better go before 02, to never break things in the history.

--
Best regards,
Vladimir