Re: [PATCH 04/37] target/i386: introduce insn_get_addr

[Richard Henderson]

On 9/12/22 00:03, Paolo Bonzini wrote:
> The "O" operand type in the Intel SDM needs to load an 8- to 64-bit
> unsigned value, while insn_get is limited to 32 bits.  Extract the code
> out of disas_insn and into a separate function.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   target/i386/tcg/translate.c | 36 ++++++++++++++++++++++++++----------
>   1 file changed, 26 insertions(+), 10 deletions(-)
>
> diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
> index f8fd93dae0..f1aa830fcc 100644
> --- a/target/i386/tcg/translate.c
> +++ b/target/i386/tcg/translate.c
> @@ -2308,6 +2308,31 @@ static void gen_ldst_modrm(CPUX86State *env, 
> DisasContext *s, int modrm,
>       }
>   }
>   
> +static inline target_ulong insn_get_addr(CPUX86State *env, DisasContext *s, MemOp ot)

No need for inline.

> +    default:
> +        tcg_abort();

Standardize on g_assert_not_reached().
I should probably zap this macro entirely...

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~