[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/4] virtio: Add shared memory capability
From: |
Bin Meng |
Subject: |
Re: [PATCH v2 1/4] virtio: Add shared memory capability |
Date: |
Tue, 13 Sep 2022 21:48:51 +0800 |
On Tue, Sep 13, 2022 at 6:57 PM Antonio Caggiano
<antonio.caggiano@collabora.com> wrote:
>
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Define a new capability type 'VIRTIO_PCI_CAP_SHARED_MEMORY_CFG'
> and the data structure 'virtio_pci_shm_cap' to go with it.
> They allow defining shared memory regions with sizes and offsets
> of 2^32 and more.
> Multiple instances of the capability are allowed and distinguished
> by a device-specific 'id'.
>
> v2: Remove virtio_pci_shm_cap as virtio_pci_cap64 is used instead.
> v3: No need for mask32 as cpu_to_le32 truncates the value.
The above changelog should be put under --- below
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Antonio Caggiano <antonio.caggiano@collabora.com>
> ---
> hw/virtio/virtio-pci.c | 18 ++++++++++++++++++
> include/hw/virtio/virtio-pci.h | 4 ++++
> 2 files changed, 22 insertions(+)
>
> diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
> index a50c5a57d7..377bb06fec 100644
> --- a/hw/virtio/virtio-pci.c
> +++ b/hw/virtio/virtio-pci.c
> @@ -1169,6 +1169,24 @@ static int virtio_pci_add_mem_cap(VirtIOPCIProxy
> *proxy,
> return offset;
> }
>
> +int virtio_pci_add_shm_cap(VirtIOPCIProxy *proxy,
> + uint8_t bar, uint64_t offset, uint64_t length,
> + uint8_t id)
> +{
> + struct virtio_pci_cap64 cap = {
> + .cap.cap_len = sizeof cap,
> + .cap.cfg_type = VIRTIO_PCI_CAP_SHARED_MEMORY_CFG,
> + };
> +
> + cap.cap.bar = bar;
> + cap.cap.length = cpu_to_le32(length);
> + cap.length_hi = cpu_to_le32(length >> 32);
> + cap.cap.offset = cpu_to_le32(offset);
> + cap.offset_hi = cpu_to_le32(offset >> 32);
> + cap.cap.id = id;
> + return virtio_pci_add_mem_cap(proxy, &cap.cap);
> +}
> +
> static uint64_t virtio_pci_common_read(void *opaque, hwaddr addr,
> unsigned size)
> {
> diff --git a/include/hw/virtio/virtio-pci.h b/include/hw/virtio/virtio-pci.h
> index 2446dcd9ae..5e5c4a4c6d 100644
> --- a/include/hw/virtio/virtio-pci.h
> +++ b/include/hw/virtio/virtio-pci.h
> @@ -252,4 +252,8 @@ void virtio_pci_types_register(const
> VirtioPCIDeviceTypeInfo *t);
> */
> unsigned virtio_pci_optimal_num_queues(unsigned fixed_queues);
>
> +int virtio_pci_add_shm_cap(VirtIOPCIProxy *proxy,
> + uint8_t bar, uint64_t offset, uint64_t length,
> + uint8_t id);
> +
> #endif
> --
Regards,
Bin
[PATCH v2 2/4] virtio-gpu: hostmem, Antonio Caggiano, 2022/09/13
[PATCH v2 1/4] virtio: Add shared memory capability, Antonio Caggiano, 2022/09/13
- Re: [PATCH v2 1/4] virtio: Add shared memory capability,
Bin Meng <=
[PATCH v2 3/4] virtio-gpu: Handle resource blob commands, Antonio Caggiano, 2022/09/13