[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 for 7.2 00/22] virtio-gpio and various virtio cleanups
From: |
Alex Bennée |
Subject: |
Re: [PATCH v4 for 7.2 00/22] virtio-gpio and various virtio cleanups |
Date: |
Fri, 16 Sep 2022 07:51:40 +0100 |
User-agent: |
mu4e 1.9.0; emacs 28.1.91 |
Alex Bennée <alex.bennee@linaro.org> writes:
> Hi,
>
> This is an update to the previous series which fixes the last few
> niggling CI failures I was seeing.
>
> Subject: [PATCH v3 for 7.2 00/21] virtio-gpio and various virtio cleanups
> Date: Tue, 26 Jul 2022 20:21:29 +0100
> Message-Id: <20220726192150.2435175-1-alex.bennee@linaro.org>
>
> The CI failures were tricky to track down because they didn't occur
> locally but after patching to dump backtraces they all seem to involve
> updates to virtio_set_status() as the machine was torn down. I think
> patch that switches all users to use virtio_device_started() along
> with consistent checking of vhost_dev->started stops this from
> happening. The clean-up seems worthwhile in reducing boilerplate
> anyway.
>
> The following patches still need review:
>
> - tests/qtest: enable tests for virtio-gpio
> - tests/qtest: add a get_features op to vhost-user-test
> - tests/qtest: implement stub for VHOST_USER_GET_CONFIG
> - tests/qtest: add assert to catch bad features
> - tests/qtest: plain g_assert for VHOST_USER_F_PROTOCOL_FEATURES
> - tests/qtest: catch unhandled vhost-user messages
> - tests/qtest: use qos_printf instead of g_test_message
> - tests/qtest: pass stdout/stderr down to subtests
> - hw/virtio: move vhd->started check into helper and add FIXME
> - hw/virtio: move vm_running check to virtio_device_started
> - hw/virtio: add some vhost-user trace events
> - hw/virtio: log potentially buggy guest drivers
> - hw/virtio: fix some coding style issues
> - include/hw: document vhost_dev feature life-cycle
> - include/hw/virtio: more comment for VIRTIO_F_BAD_FEATURE
> - hw/virtio: fix vhost_user_read tracepoint
> - hw/virtio: handle un-configured shutdown in virtio-pci
> - hw/virtio: gracefully handle unset vhost_dev vdev
> - hw/virtio: incorporate backend features in features
<snip>
Ping?
--
Alex Bennée
- Re: [PATCH v4 for 7.2 00/22] virtio-gpio and various virtio cleanups,
Alex Bennée <=