Re: [PATCH v4 2/3] module: add Error arguments to module_load_one and module_load_qom_one

[Richard Henderson]

On 9/8/22 20:30, Claudio Fontana wrote:
> improve error handling during module load, by changing:
>
> bool module_load_one(const char *prefix, const char *lib_name);
> void module_load_qom_one(const char *type);
>
> to:
>
> bool module_load_one(const char *prefix, const char *name, Error **errp);
> bool module_load_qom_one(const char *type, Error **errp);
>
> module_load_qom_one has been introduced in:
>
> commit 28457744c345 ("module: qom module support"), which built on top of
> module_load_one, but discarded the bool return value. Restore it.
>
> Adapt all callers to emit errors, or ignore them, or fail hard,
> as appropriate in each context.
>
> Signed-off-by: Claudio Fontana<cfontana@suse.de>
> ---
>   audio/audio.c         |   9 ++-
>   block.c               |  15 ++++-
>   block/dmg.c           |  18 +++++-
>   hw/core/qdev.c        |  10 ++-
>   include/qemu/module.h |  38 ++++++++++--
>   qom/object.c          |  18 +++++-
>   softmmu/qtest.c       |   6 +-
>   ui/console.c          |  18 +++++-
>   util/module.c         | 140 ++++++++++++++++++++++++------------------
>   9 files changed, 194 insertions(+), 78 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~