[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C |
Date: |
Fri, 16 Sep 2022 10:18:52 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Ani Sinha <ani@anisinha.ca> writes:
> On Fri, Sep 16, 2022 at 2:13 AM Markus Armbruster <armbru@redhat.com> wrote:
>>
>> The has_FOO for pointer-valued FOO are redundant, except for arrays.
>> They are also a nuisance to work with. Recent commit "qapi: Start to
>> elide redundant has_FOO in generated C"
>
> Commit is referenced using <commit hash 13 chars min> ("commit header")
Apply my patches in your tree, and your hashes will differ from mine.
Hashes can serve as stable reference only when we git-fetch patches, not
when we git-send-email then.
>> provided the means to elide
>> them step by step. This is the step for qapi/acpi.py.
>>
>> Said commit explains the transformation in more detail. The invariant
>> violations mentioned there do not occur here.
>>
>> Cc: Michael S. Tsirkin <mst@redhat.com>
>> Cc: Igor Mammedov <imammedo@redhat.com>
>> Cc: Ani Sinha <ani@anisinha.ca>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
- [PATCH 18/27] qapi qdev qom: Elide redundant has_FOO in generated C, (continued)
- [PATCH 18/27] qapi qdev qom: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- [PATCH 16/27] qapi net: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- [PATCH 23/27] qapi tpm: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- [PATCH 20/27] qapi rocker: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- [PATCH 01/27] docs/devel/qapi-code-gen: Update example to match current code, Markus Armbruster, 2022/09/15
- [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C, Igor Mammedov, 2022/09/16
- Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C, Ani Sinha, 2022/09/16
- Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C,
Markus Armbruster <=
- Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C, Ani Sinha, 2022/09/16
- Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C, Daniel P . Berrangé, 2022/09/16
- Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C, Ani Sinha, 2022/09/16
- Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C, Ani Sinha, 2022/09/16
- Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/16
Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C, Daniel P . Berrangé, 2022/09/16
[PATCH 26/27] qapi qga: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
[PATCH 10/27] qapi crypto: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
[PATCH 22/27] qapi stats: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15