[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C |
Date: |
Fri, 16 Sep 2022 09:37:55 +0100 |
User-agent: |
Mutt/2.2.6 (2022-06-05) |
On Fri, Sep 16, 2022 at 01:51:14PM +0530, Ani Sinha wrote:
> On Fri, Sep 16, 2022 at 1:48 PM Markus Armbruster <armbru@redhat.com> wrote:
> >
> > Ani Sinha <ani@anisinha.ca> writes:
> >
> > > On Fri, Sep 16, 2022 at 2:13 AM Markus Armbruster <armbru@redhat.com>
> > > wrote:
> > >>
> > >> The has_FOO for pointer-valued FOO are redundant, except for arrays.
> > >> They are also a nuisance to work with. Recent commit "qapi: Start to
> > >> elide redundant has_FOO in generated C"
> > >
> > > Commit is referenced using <commit hash 13 chars min> ("commit header")
> >
> > Apply my patches in your tree, and your hashes will differ from mine.
> > Hashes can serve as stable reference only when we git-fetch patches, not
> > when we git-send-email then.
>
> Has the referenced patch not been pushed upstream already? I thought
> it was and hence was asking for the reference.
Err, it is just a few patches earlier in this very series you're
looking at.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 23/27] qapi tpm: Elide redundant has_FOO in generated C, (continued)
- [PATCH 23/27] qapi tpm: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- [PATCH 20/27] qapi rocker: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- [PATCH 01/27] docs/devel/qapi-code-gen: Update example to match current code, Markus Armbruster, 2022/09/15
- [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C, Igor Mammedov, 2022/09/16
- Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C, Ani Sinha, 2022/09/16
- Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/16
- Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C, Ani Sinha, 2022/09/16
- Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C,
Daniel P . Berrangé <=
- Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C, Ani Sinha, 2022/09/16
- Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C, Ani Sinha, 2022/09/16
- Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/16
Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C, Daniel P . Berrangé, 2022/09/16
[PATCH 26/27] qapi qga: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
[PATCH 10/27] qapi crypto: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
[PATCH 22/27] qapi stats: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
[PATCH 13/27] qapi machine: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15