[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 25/27] qapi ui: Elide redundant has_FOO in generated C
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 25/27] qapi ui: Elide redundant has_FOO in generated C |
Date: |
Fri, 16 Sep 2022 10:04:26 +0100 |
User-agent: |
Mutt/2.2.6 (2022-06-05) |
On Thu, Sep 15, 2022 at 10:43:15PM +0200, Markus Armbruster wrote:
> The has_FOO for pointer-valued FOO are redundant, except for arrays.
> They are also a nuisance to work with. Recent commit "qapi: Start to
> elide redundant has_FOO in generated C" provided the means to elide
> them step by step. This is the step for qapi/ui.json.
>
> Said commit explains the transformation in more detail. The invariant
> violations mentioned there do not occur here.
>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> monitor/hmp-cmds.c | 12 ++++--------
> ui/console.c | 4 ++--
> ui/input.c | 4 ++--
> ui/spice-core.c | 5 -----
> ui/vnc.c | 10 ----------
> scripts/qapi/schema.py | 1 -
> 6 files changed, 8 insertions(+), 28 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C, (continued)
- [PATCH 26/27] qapi qga: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- [PATCH 10/27] qapi crypto: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- [PATCH 22/27] qapi stats: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- [PATCH 13/27] qapi machine: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- [PATCH 25/27] qapi ui: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- Re: [PATCH 25/27] qapi ui: Elide redundant has_FOO in generated C,
Daniel P . Berrangé <=
- [PATCH 27/27] qapi: Drop temporary logic to support conversion step by step, Markus Armbruster, 2022/09/15
- Re: [PATCH 00/27] qapi: Elide redundant has_FOO in generated C, Vladimir Sementsov-Ogievskiy, 2022/09/16