qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C


From: Markus Armbruster
Subject: Re: [PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C
Date: Fri, 16 Sep 2022 11:35:40 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Ani Sinha <ani@anisinha.ca> writes:

> On Fri, Sep 16, 2022 at 14:08 Daniel P. Berrangé <berrange@redhat.com>
> wrote:
>
>> On Fri, Sep 16, 2022 at 01:51:14PM +0530, Ani Sinha wrote:
>> > On Fri, Sep 16, 2022 at 1:48 PM Markus Armbruster <armbru@redhat.com> 
>> > wrote:
>> > >
>> > > Ani Sinha <ani@anisinha.ca> writes:
>> > >
>> > > > On Fri, Sep 16, 2022 at 2:13 AM Markus Armbruster <armbru@redhat.com> 
>> > > > wrote:
>> > > >>
>> > > >> The has_FOO for pointer-valued FOO are redundant, except for arrays.
>> > > >> They are also a nuisance to work with.  Recent commit "qapi: Start to
>> > > >> elide redundant has_FOO in generated C"
>> > > >
>> > > > Commit is referenced using <commit hash 13 chars min> ("commit header")
>> > >
>> > > Apply my patches in your tree, and your hashes will differ from mine.
>> > > Hashes can serve as stable reference only when we git-fetch patches, not
>> > > when we git-send-email then.
>> >
>> > Has the referenced patch not been pushed upstream already? I thought
>> > it was and hence was asking for the reference.
>>
>> Err, it is just a few patches earlier in this very series you're
>> looking at.
>
>
> Hmm ok. It’s missing from my inbox. Probably was not CC’d to me.

Yes.  I'm sorry for the confusion!




reply via email to

[Prev in Thread] Current Thread [Next in Thread]