Re: [PATCH v2] hw/display: load the correct ROM file for isa-vga device

[Liav Albani]

On 9/17/22 17:40, Liav Albani wrote:
> On 9/17/22 17:32, Liav Albani wrote:
>
> > diff --git a/pc-bios/meson.build b/pc-bios/meson.build
> > index 388e0db6e4..6af94a4a0a 100644
> > --- a/pc-bios/meson.build
> > +++ b/pc-bios/meson.build
> > @@ -29,7 +29,7 @@ blobs = [
> >     'bios-microvm.bin',
> >     'qboot.rom',
> >     'sgabios.bin',
> > -  'vgabios.bin',
> > +  'vgabios-isavga.bin',
> >     'vgabios-cirrus.bin',
> Well, it seems like this one doesn't want to be compiled now, so I'll 
> need to dive deeper to figure out how to ensure it always produces the 
> requested file.

So apparently the problem on my development machine is that for some odd 
reason I don't have the "vgabios.bin" file, but I do have
the "vgabios-isavga.bin" file. According to my package manager (pacman), 
it is owned by the SeaBIOS package:

    usr/share/qemu/vgabios-isavga.bin is owned by extra/seabios 1.15.0-1

Other files in that directory are owned by the same package as well, for 
example:

    usr/share/qemu/vgabios-stdvga.bin is owned by extra/seabios 1.15.0-1
    usr/share/qemu/vgabios-virtio.bin is owned by extra/seabios 1.15.0-1
    usr/share/qemu/vgabios-vmware.bin is owned by extra/seabios 1.15.0-1

So I'm not sure what is the best approach here to fix this. It is 
definitely not a problem in QEMU because when I compile it from source I 
do get a "vgabios.bin" file in the build directory, but I do think that 
QEMU should try to use the "vgabios-isavga.bin" file when using the 
isa-vga device, so in some way we could fix it in QEMU, which also makes 
sense to ensure the filename is "vgabios-isavga.bin" for the isa-vga 
device and not plain "vgabios.bin", which really doesn't say much about 
the type of the graphics device.

> >     'vgabios-stdvga.bin',
> >     'vgabios-vmware.bin',