qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/7] scripts/nsis.py: Fix destination directory name when inv


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 2/7] scripts/nsis.py: Fix destination directory name when invoked on Windows
Date: Sat, 17 Sep 2022 23:20:24 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 8/9/22 15:28, Bin Meng wrote:
From: Bin Meng <bin.meng@windriver.com>

"make installer" on Windows fails with the following message:

   Traceback (most recent call last):
     File "G:\msys64\home\foo\git\qemu\scripts\nsis.py", line 89, in <module>
       main()
     File "G:\msys64\home\foo\git\qemu\scripts\nsis.py", line 34, in main
       with open(
   OSError: [Errno 22] Invalid argument:
   'R:/Temp/tmpw83xhjquG:/msys64/qemu/system-emulations.nsh'
   ninja: build stopped: subcommand failed.

Use os.path.splitdrive() to form a canonical path without the drive
letter on Windows. This works with cross-build on Linux too.

Fixes: 8adfeba953e0 ("meson: add NSIS building")
Signed-off-by: Bin Meng <bin.meng@windriver.com>
---

  scripts/nsis.py | 12 +++++++-----
  1 file changed, 7 insertions(+), 5 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]